1910/Resolve issue with HouseholdSizeField #1991
Conversation
|
👷 Deploy request for dev-bloom pending review. 🔨 Explore the source changes: c34f38a |
|
👷 Deploy request for dev-partners-bloom pending review. 🔨 Explore the source changes: c34f38a |
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| </> | ||
| )} | ||
| <span className="hidden"> | ||
| <input |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
|
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: c34f38a 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/616f17b04833bc00074ac21c 😎 Browse the preview: https://deploy-preview-1991--dev-storybook-bloom.netlify.app |
|
Make sure you add the |
CHANGELOG.md
Outdated
| @@ -70,6 +70,7 @@ All notable changes to this project will be documented in this file. The format | |||
| - StandardTable styling bug ([#1632](https://github.com/bloom-housing/bloom/pull/1632)) (Emily Jablonski) | |||
| - More robust Features section for public listing view ([#1688](https://github.com/bloom-housing/bloom/pull/1688)) | |||
| - A11Y issues with the image tint in ImageCard ([#1964](https://github.com/bloom-housing/bloom/pull/1964)) (Emily Jablonski) | |||
| - HouseholdSizeField bug when householdSizeMax is 0 ([#1910](https://github.com/bloom-housing/bloom/issues/1910)) (Yazeed) | |||
There was a problem hiding this comment.
This should be the PR number - look at the links above that use /pull
|
@emilyjablonski ty ty! |
|
You've got some failing tests to look at :) |
|
@YazeedLoonat , see @emilyjablonski's comment on the failing tests. |
|
Hey @emilyjablonski from talking with sean and testing it out I'm pretty sure the remaining failure is related to #2024 and we may wanna spin up a separate ticketo to address it. Everything else should be good to go now |
|
@YazeedLoonat How do I create a listing with a household max size of 0? |
* fix: householdSizeField hidden when householdSizeMax is 0
Issue
#1910
Addresses #issue
Description
Resolves an issue where the HouseholdSizeField was displaying 0 when householdSizeMax was set to 0. Even though it shouldn't have displayed at all
Type of change
How Can This Be Tested/Reviewed?
If you have the ability to, create a listing where the house hold size max is set to 0, then test out the application process.
Once you get to the "Next we would like to know about the other people who will live with you in the unit" notice that a random 0 is NOT displayed on the page anymore
Checklist:
yarn generate:clientif I made backend changes