Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: passwordless frontend #3941

Merged
merged 5 commits into from
Mar 18, 2024
Merged

feat: passwordless frontend #3941

merged 5 commits into from
Mar 18, 2024

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Mar 11, 2024

Pull Request Template

Issue Overview

This PR addresses #3892

  • This change addresses only certain aspects of the issue

Description

Includes just the frontend for the sign-in screen and the verify screen.

How Can This Be Tested/Reviewed?

This will just be a visual QA. Designs are here.

Turn on the passwordless environment variable to view the sign in page. You will be able to toggle between the code and password versions.

Visit /verify to view the verify page. The alert copy and links included are based on the create account screens (the sign-in screens have different alert copy and links). Including the differences between the sign-in and create account versions will be added when the backend is complete.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 9b5a9e4
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/65f0b03595f44f000824f2e1
😎 Deploy Preview https://deploy-preview-3941--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit f53d9b4
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/65f0b0f60265b00009cd885e
😎 Deploy Preview https://deploy-preview-3941--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 6d6508a
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/65f0b51e369ef50008cfa9ca
😎 Deploy Preview https://deploy-preview-3941--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emilyjablonski emilyjablonski added the 1 review needed Requires 1 more review before ready to merge label Mar 12, 2024
@emilyjablonski emilyjablonski marked this pull request as ready for review March 12, 2024 20:16
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just found some very minor discrepancies with the Figma. I think a few of them conflict with the uic-patterns so I trust your judgement on where to match!

(The red spacing measurements are the points of discrepancy)
Screenshot 2024-03-13 at 3 59 22 PM
Screenshot 2024-03-13 at 3 51 00 PM

@ColinBuyck ColinBuyck removed the 1 review needed Requires 1 more review before ready to merge label Mar 13, 2024
@emilyjablonski
Copy link
Collaborator Author

Yeah unfortunately all of those styles look like they live in UIC or Seeds, will def connect w design on the discrepancies!

@emilyjablonski emilyjablonski merged commit fc912c8 into main Mar 18, 2024
20 checks passed
YazeedLoonat pushed a commit to housingbayarea/bloom that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants