-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: various uptake and visual enhancements to address design QA #4038
Conversation
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@emilyjablonski I thought I had gone through Figma and pulled out the right spacing values, but I'll go double-check. |
@emilyjablonski I made a few updates based on your feedback and I think it's closer now. In cases where there seemed to be a discrepancy between the token name in Figma and what looks most identical in code practice, I went with what looked accurate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…om-housing#4038) * fix: various uptake and visual enhancements to address design QA * fix: prettier * fix: feedback from QA (cherry picked from commit 71c8a16)
…om-housing#4038) * fix: various uptake and visual enhancements to address design QA * fix: prettier * fix: feedback from QA (cherry picked from commit 71c8a16)
* feat: uptake of Seeds Toast component (bloom-housing#3962) * Squashed commit of the following: commit d964056 Author: Jared White <jared@jaredwhite.com> Date: Mon Jan 22 15:41:22 2024 -0800 feat: adjust Seeds Toast inset commit 75b1e07 Author: Jared White <jared@jaredwhite.com> Date: Thu Jan 18 14:29:03 2024 -0800 test: get partners unit tests to pass commit af89871 Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 17 22:18:31 2024 -0800 fix: more linting commit fca3211 Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 17 21:50:21 2024 -0800 fix: another lint error commit 22243fe Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 17 20:38:39 2024 -0800 fix: lint issues commit 1168e02 Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 17 19:25:19 2024 -0800 feat: switch a number of site alert features to Toast commit 4309bda Author: Jared White <jared@jaredwhite.com> Date: Mon Jan 15 16:58:06 2024 -0800 feat: toast message context now working as expected commit 0835000 Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 10 20:50:36 2024 -0800 chore: bump Seeds version commit 1feceb8 Merge: 5047464 dbcd45c Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 10 20:37:42 2024 -0800 Merge commit 'dbcd45cf1060dc955e71e4dd11720c75a92efc3d' into 3434/react-context-messaging commit 5047464 Author: Morgan Ludtke <ludtkemorgan@gmail.com> Date: Tue Oct 17 10:59:54 2023 -0500 fix: email csv fix commit 19cd8b2 Author: Morgan Ludtke <ludtkemorgan@gmail.com> Date: Tue Oct 17 10:34:42 2023 -0500 fix: review comments commit fc220a7 Author: Morgan Ludtke <ludtkemorgan@gmail.com> Date: Fri Oct 6 15:41:25 2023 -0500 fix: add comment commit 4aa3cfb Author: ColinBuyck <colin.buyck@gmail.com> Date: Thu Jul 6 21:04:09 2023 -0700 fix: uptake toast component * feat: strip out old SiteAlert code in favor of toasts * fix: lint issues * fix: more linting * test: fix tests due to new Toasts * feat: fix some timing/context issues with Toast * fix: type error * fix: type error redux * fix: update React types to clean up false errors * fix: add back missing toast, use Seeds size tokens (cherry picked from commit e7cf68d) * feat: add Hero icons and additional uptake of Seeds Icon (bloom-housing#3956) * feat: add Hero icons, utilize Icon Map infra * feat: add Hero icons to more places throughout the system * fix: prettier * fix: prettier * fix: prettier test file * fix: build errors * fix: outlined icons (cherry picked from commit 552c517) * feat: uptake Seeds Tabs (bloom-housing#3993) * Squashed commit of the following: commit d964056 Author: Jared White <jared@jaredwhite.com> Date: Mon Jan 22 15:41:22 2024 -0800 feat: adjust Seeds Toast inset commit 75b1e07 Author: Jared White <jared@jaredwhite.com> Date: Thu Jan 18 14:29:03 2024 -0800 test: get partners unit tests to pass commit af89871 Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 17 22:18:31 2024 -0800 fix: more linting commit fca3211 Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 17 21:50:21 2024 -0800 fix: another lint error commit 22243fe Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 17 20:38:39 2024 -0800 fix: lint issues commit 1168e02 Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 17 19:25:19 2024 -0800 feat: switch a number of site alert features to Toast commit 4309bda Author: Jared White <jared@jaredwhite.com> Date: Mon Jan 15 16:58:06 2024 -0800 feat: toast message context now working as expected commit 0835000 Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 10 20:50:36 2024 -0800 chore: bump Seeds version commit 1feceb8 Merge: 5047464 dbcd45c Author: Jared White <jared@jaredwhite.com> Date: Wed Jan 10 20:37:42 2024 -0800 Merge commit 'dbcd45cf1060dc955e71e4dd11720c75a92efc3d' into 3434/react-context-messaging commit 5047464 Author: Morgan Ludtke <ludtkemorgan@gmail.com> Date: Tue Oct 17 10:59:54 2023 -0500 fix: email csv fix commit 19cd8b2 Author: Morgan Ludtke <ludtkemorgan@gmail.com> Date: Tue Oct 17 10:34:42 2023 -0500 fix: review comments commit fc220a7 Author: Morgan Ludtke <ludtkemorgan@gmail.com> Date: Fri Oct 6 15:41:25 2023 -0500 fix: add comment commit 4aa3cfb Author: ColinBuyck <colin.buyck@gmail.com> Date: Thu Jul 6 21:04:09 2023 -0700 fix: uptake toast component * feat: strip out old SiteAlert code in favor of toasts * fix: lint issues * fix: more linting * test: fix tests due to new Toasts * feat: fix some timing/context issues with Toast * fix: type error * fix: type error redux * fix: update React types to clean up false errors * feat: switch to Seeds Tabs in the Partners app (cherry picked from commit 2fcb5a6) * feat: uptake additional Seeds icons * fix: linting * fix: correct JSX syntax * fix: duplicate statement * fix: icon size * fix: use simpler icon syntax in Markdown * fix: icons in other jurisdiction content * fix: various uptake and visual enhancements to address design QA (bloom-housing#4038) * fix: various uptake and visual enhancements to address design QA * fix: prettier * fix: feedback from QA (cherry picked from commit 71c8a16) * fix: backport better icons for sign up/in from Doorway
Issue Overview
This PR addresses #3985
Description
This PR includes changes/fixes to the household members portion and the Review summary portion of Common App to align with Seeds and maintain a consistent visual apperance.
How Can This Be Tested/Reviewed?
You can go to a listing here: https://deploy-preview-4038--bloom-exygy-dev.netlify.app/listing/f0ea701c-e488-45aa-ad48-ec73ab4e757a/testing_paper_67_montezuma_st_san_francisco_ca
and then fill out an application.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.