Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various uptake and visual enhancements to address design QA #4038

Merged
merged 4 commits into from
May 24, 2024

Conversation

jaredcwhite
Copy link
Collaborator

@jaredcwhite jaredcwhite commented Apr 23, 2024

Issue Overview

This PR addresses #3985

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This PR includes changes/fixes to the household members portion and the Review summary portion of Common App to align with Seeds and maintain a consistent visual apperance.

How Can This Be Tested/Reviewed?

You can go to a listing here: https://deploy-preview-4038--bloom-exygy-dev.netlify.app/listing/f0ea701c-e488-45aa-ad48-ec73ab4e757a/testing_paper_67_montezuma_st_san_francisco_ca
and then fill out an application.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 1509e04
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/664259a705ba12000891d468
😎 Deploy Preview https://deploy-preview-4038--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaredcwhite jaredcwhite added the 1 review needed Requires 1 more review before ready to merge label May 3, 2024
@emilyjablonski
Copy link
Collaborator

emilyjablonski commented May 3, 2024

Screenshot 2024-05-03 at 2 19 50 PM I'm not seeing the values from the Figma reflected here, looking at the two notes on the side about the spacing between sections and between the label and value for example. I'm seeing the same w the notes for the summary page.

@jaredcwhite
Copy link
Collaborator Author

@emilyjablonski I thought I had gone through Figma and pulled out the right spacing values, but I'll go double-check.

@jaredcwhite
Copy link
Collaborator Author

@emilyjablonski I made a few updates based on your feedback and I think it's closer now. In cases where there seemed to be a discrepancy between the token name in Figma and what looks most identical in code practice, I went with what looked accurate.

Copy link
Collaborator

@slowbot slowbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredcwhite jaredcwhite merged commit 71c8a16 into main May 24, 2024
20 checks passed
jaredcwhite added a commit to metrotranscom/doorway that referenced this pull request May 28, 2024
…om-housing#4038)

* fix: various uptake and visual enhancements to address design QA

* fix: prettier

* fix: feedback from QA

(cherry picked from commit 71c8a16)
jaredcwhite added a commit to housingbayarea/bloom that referenced this pull request May 28, 2024
…om-housing#4038)

* fix: various uptake and visual enhancements to address design QA

* fix: prettier

* fix: feedback from QA

(cherry picked from commit 71c8a16)
jaredcwhite added a commit to housingbayarea/bloom that referenced this pull request Jun 27, 2024
* feat: uptake of Seeds Toast component (bloom-housing#3962)

* Squashed commit of the following:

commit d964056
Author: Jared White <jared@jaredwhite.com>
Date:   Mon Jan 22 15:41:22 2024 -0800

    feat: adjust Seeds Toast inset

commit 75b1e07
Author: Jared White <jared@jaredwhite.com>
Date:   Thu Jan 18 14:29:03 2024 -0800

    test: get partners unit tests to pass

commit af89871
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 17 22:18:31 2024 -0800

    fix: more linting

commit fca3211
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 17 21:50:21 2024 -0800

    fix: another lint error

commit 22243fe
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 17 20:38:39 2024 -0800

    fix: lint issues

commit 1168e02
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 17 19:25:19 2024 -0800

    feat: switch a number of site alert features to Toast

commit 4309bda
Author: Jared White <jared@jaredwhite.com>
Date:   Mon Jan 15 16:58:06 2024 -0800

    feat: toast message context now working as expected

commit 0835000
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 10 20:50:36 2024 -0800

    chore: bump Seeds version

commit 1feceb8
Merge: 5047464 dbcd45c
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 10 20:37:42 2024 -0800

    Merge commit 'dbcd45cf1060dc955e71e4dd11720c75a92efc3d' into 3434/react-context-messaging

commit 5047464
Author: Morgan Ludtke <ludtkemorgan@gmail.com>
Date:   Tue Oct 17 10:59:54 2023 -0500

    fix: email csv fix

commit 19cd8b2
Author: Morgan Ludtke <ludtkemorgan@gmail.com>
Date:   Tue Oct 17 10:34:42 2023 -0500

    fix: review comments

commit fc220a7
Author: Morgan Ludtke <ludtkemorgan@gmail.com>
Date:   Fri Oct 6 15:41:25 2023 -0500

    fix: add comment

commit 4aa3cfb
Author: ColinBuyck <colin.buyck@gmail.com>
Date:   Thu Jul 6 21:04:09 2023 -0700

    fix: uptake toast component

* feat: strip out old SiteAlert code in favor of toasts

* fix: lint issues

* fix: more linting

* test: fix tests due to new Toasts

* feat: fix some timing/context issues with Toast

* fix: type error

* fix: type error redux

* fix: update React types to clean up false errors

* fix: add back missing toast, use Seeds size tokens

(cherry picked from commit e7cf68d)

* feat: add Hero icons and additional uptake of Seeds Icon (bloom-housing#3956)

* feat: add Hero icons, utilize Icon Map infra

* feat: add Hero icons to more places throughout the system

* fix: prettier

* fix: prettier

* fix: prettier test file

* fix: build errors

* fix: outlined icons

(cherry picked from commit 552c517)

* feat: uptake Seeds Tabs (bloom-housing#3993)

* Squashed commit of the following:

commit d964056
Author: Jared White <jared@jaredwhite.com>
Date:   Mon Jan 22 15:41:22 2024 -0800

    feat: adjust Seeds Toast inset

commit 75b1e07
Author: Jared White <jared@jaredwhite.com>
Date:   Thu Jan 18 14:29:03 2024 -0800

    test: get partners unit tests to pass

commit af89871
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 17 22:18:31 2024 -0800

    fix: more linting

commit fca3211
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 17 21:50:21 2024 -0800

    fix: another lint error

commit 22243fe
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 17 20:38:39 2024 -0800

    fix: lint issues

commit 1168e02
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 17 19:25:19 2024 -0800

    feat: switch a number of site alert features to Toast

commit 4309bda
Author: Jared White <jared@jaredwhite.com>
Date:   Mon Jan 15 16:58:06 2024 -0800

    feat: toast message context now working as expected

commit 0835000
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 10 20:50:36 2024 -0800

    chore: bump Seeds version

commit 1feceb8
Merge: 5047464 dbcd45c
Author: Jared White <jared@jaredwhite.com>
Date:   Wed Jan 10 20:37:42 2024 -0800

    Merge commit 'dbcd45cf1060dc955e71e4dd11720c75a92efc3d' into 3434/react-context-messaging

commit 5047464
Author: Morgan Ludtke <ludtkemorgan@gmail.com>
Date:   Tue Oct 17 10:59:54 2023 -0500

    fix: email csv fix

commit 19cd8b2
Author: Morgan Ludtke <ludtkemorgan@gmail.com>
Date:   Tue Oct 17 10:34:42 2023 -0500

    fix: review comments

commit fc220a7
Author: Morgan Ludtke <ludtkemorgan@gmail.com>
Date:   Fri Oct 6 15:41:25 2023 -0500

    fix: add comment

commit 4aa3cfb
Author: ColinBuyck <colin.buyck@gmail.com>
Date:   Thu Jul 6 21:04:09 2023 -0700

    fix: uptake toast component

* feat: strip out old SiteAlert code in favor of toasts

* fix: lint issues

* fix: more linting

* test: fix tests due to new Toasts

* feat: fix some timing/context issues with Toast

* fix: type error

* fix: type error redux

* fix: update React types to clean up false errors

* feat: switch to Seeds Tabs in the Partners app

(cherry picked from commit 2fcb5a6)

* feat: uptake additional Seeds icons

* fix: linting

* fix: correct JSX syntax

* fix: duplicate statement

* fix: icon size

* fix: use simpler icon syntax in Markdown

* fix: icons in other jurisdiction content

* fix: various uptake and visual enhancements to address design QA (bloom-housing#4038)

* fix: various uptake and visual enhancements to address design QA

* fix: prettier

* fix: feedback from QA

(cherry picked from commit 71c8a16)

* fix: backport better icons for sign up/in from Doorway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 review needed Requires 1 more review before ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants