Change default build type to 64-bits on 64-bit systems. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the mechanism used to determine the system's processor type from various mechanisms to Python's "platform.machine()" library function. It uses this information to change the default for the --abi-bits parameter to the 'configure' command. In addition, it separates the code that determines this information from the code that determines the compiler type and version, as those are unrelated operations.
Closed
|
Worked nicely for my build. Thanks! |
|
Internal ticket reference 53452398 |
|
The build system has been moved to another repository: https://github.com/bloomberg/bde-tools Please submit another pull request for that repository. I recommend splitting the changeset into two parts, one for changing default abi bits depending on the platform, and another for updating the way the CPU name of the UPLID is acquired. I believe the first part probably can be merged without further changes. The second part of the has some issues (on Windows), please see https://review.openbloomberg.com/D129 for more details. |
abeels
added a commit
that referenced
this pull request
Feb 11, 2016
commit 1ad050d Merge: 80cc5ab 28c27a6 Date: Wed Jan 27 14:53:08 2016 -0500 Merge pull request #116 from hrosen4/bdlmt_threadpool-dtor-doc_drqs-76512668 bdlmt_threadpool: Correct/clarify destructor documentation. commit 28c27a6 Date: Tue Jan 19 18:01:19 2016 -0500 Correct/clarify destructor documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the mechanism used to determine the system's processor type
from various mechanisms to Python's "platform.machine()" library function. It
uses this information to change the default for the --abi-bits parameter to
the 'configure' command.
In addition, it separates the code that determines this information from the code
that determines the compiler type and version, as those are unrelated operations.