bsls_platform: Updated Clang GCC version selection #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2014
|
Please be sure not to refer to this as 'full C++11 support' in anything that is committed; GCC 4.8.x only provides full C++11 language support, not full library support. |
Clang, by default, defines pre-processor macros that indicate the compiler is GCC and that it is specifically version 4.2.1. BDE already previously overrode this selection to indicate version 4.4.0 because Clang supports features found in the latest version(s) of GCC. This change makes Clang >= 3.3 mimic GCC 4.8.1, as both compilers were the first versions to be C++ compliant in terms of compiler features. This will make Clang >= 3.3 compilation correctly include GCC atomic intrinsics that are present only in GCC >= 4.7.
apaprocki
force-pushed
the
bsls-platform-clang-cmp-version
branch
from
8be3cfc
to
f65fd4f
Compare
|
@kpfleming I updated the comment to be more diplomatic :) |
|
Tracked along with bloomberg/bde-tools#6 as internal issue #58997308 |
|
#169 and #169 are alternative to this pull request and more aggressive in treating Clang as an independent compiler, whereas this commit masquerades as a more recent version of GCC. bloomberg/bde-tools#6 is still relevant to either choice. |
|
#169 has been merged, taking an alternative appoarch to this pull request. Can this pull request be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang, by default, defines pre-processor macros that indicate the
compiler is GCC and that it is specifically version 4.2.1. BDE
already previously overrode this selection to indicate version
4.4.0 because Clang supports features found in the latest version(s)
of GCC. This change makes Clang >= 3.3 mimic GCC 4.8.1, as both
compilers were the first versions to be C++ compliant in terms of
compiler features. This will make Clang >= 3.3 compilation correctly
include GCC atomic intrinsics that are present only in GCC >= 4.7.