Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Showcase temporal flamegraphs #412

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

mgmacias95
Copy link
Contributor

Issue number of the reported bug or feature request: #392

Describe your changes
Add a sample program that showcases temporal flamegraphs following indications at #392 (comment)

Testing performed
Built docs and manually checked on my browser.

@godlygeek
Copy link
Contributor

Would you mind formatting the Python code with Black, and then adding a DCO sign-off to your commit message? You can add the DCO sign-off with git commit -a --amend -s

@mgmacias95
Copy link
Contributor Author

hi @godlygeek,

I fixed the signed-off commit message, formatted the code using black, fixed linter issues and, in addition, I linked the example in the temporal flamegraph section in the docs. PTAL.

Signed-off-by: Marta Gómez Macías <mgmacias@google.com>
Signed-off-by: Marta Gómez Macías <mgmacias@google.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution, @mgmacias95!

@godlygeek godlygeek enabled auto-merge (rebase) June 30, 2023 16:27
@godlygeek godlygeek merged commit 362a348 into bloomberg:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants