Set our recursion guard in all hooks #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
set_recursion_guard_in_all_hooks
branch
from
88579db
to
741a25d
Compare
This prevents reentrancy if one hooked function calls into another. For instance, the jemalloc implementation of `malloc` calls into `mmap` while holding a lock, and our `mmap` hook calls `malloc`, so we must prevent our `mmap` hook from running beneath our `malloc` hook. Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
godlygeek
force-pushed
the
set_recursion_guard_in_all_hooks
branch
from
741a25d
to
88c5853
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 90 90
Lines 10503 10520 +17
Branches 1446 1446
==========================================
+ Hits 9634 9649 +15
- Misses 866 868 +2
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pablogsal
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents reentrancy if one hooked function calls into another. For instance, the jemalloc implementation of
malloccalls intommapwhile holding a lock, and ourmmaphook callsmalloc, so we must prevent ourmmaphook from running beneath ourmallochook.Closes #336