Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a binding for Ctrl-Z to memray tree #581

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

pablogsal
Copy link
Member

CTRL+z to suspend isn't enabled by default, but we can add it with a keybinding.

Closes: #559

setup.py Outdated Show resolved Hide resolved
@godlygeek
Copy link
Contributor

I've pushed a fixup here that gets this somewhere where I'm happy with it. Take a look, @pablogsal

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (41248ed) to head (ef63b83).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   92.55%   92.94%   +0.39%     
==========================================
  Files          91       91              
  Lines       11304    11195     -109     
  Branches     1581     2047     +466     
==========================================
- Hits        10462    10405      -57     
+ Misses        837      790      -47     
+ Partials        5        0       -5     
Flag Coverage Δ
cpp 92.94% <ø> (+7.00%) ⬆️
python_and_cython 92.94% <ø> (-2.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CTRL+z to suspend isn't enabled by default, but we can add it with a
keybinding.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit a9b4d1c into bloomberg:main Apr 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl-Z in "memray tree" doesn't work
3 participants