Fix docs building in CI #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we link directly against `libdebuginfod`, we need the package that provides it installed in every environment we build in. Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 92.55% 92.89% +0.34%
==========================================
Files 91 92 +1
Lines 11304 11236 -68
Branches 1581 2058 +477
==========================================
- Hits 10462 10438 -24
+ Misses 837 798 -39
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Now that we link directly to libdebuginfod.so, we need that library to be available whenever we're built from source. Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
Now that we link directly to libdebuginfod.so, we need that library to be available whenever we're built from source. Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
godlygeek
force-pushed
the
fix_ci_docs_building
branch
from
afcdab5
to
28b6ab5
Compare
pablogsal
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix docs building in CI. This was broken by #592, but wasn't noticed until the PR landed because the workflow only runs on main, not PRs.