gold task #125
Merged
gold task #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1045
💛 - Coveralls |
dchhabda
force-pushed
the
1287-gold-task
branch
from
de51e18
to
c22e571
Compare
dchhabda
force-pushed
the
1287-gold-task
branch
3 times, most recently
from
ee1b415
to
2b114bc
Compare
fiorda
reviewed
Oct 29, 2018
pybossa/api/task.py
Outdated
| @@ -72,6 +76,13 @@ def _preprocess_post_data(self, data): | |||
| if invalid_fields: | |||
| raise BadRequest('Missing or incorrect required fields: {}' | |||
| .format(','.join(invalid_fields))) | |||
| if data.get('gold_answers', None): | |||
pybossa/api/task.py
Outdated
| if data.get('gold_answers', None): | ||
| try: | ||
| gold_answers = data['gold_answers'] | ||
| if type(gold_answers) is dict and json.dumps(gold_answers): |
There was a problem hiding this comment.
What cold go wrong? Isn't the data already parsed from json?
pybossa/api/task.py
Outdated
| current_user.id in get_project_data(project_id)['owners_ids']): | ||
| return data | ||
| else: | ||
| tmp = copy.deepcopy(data) |
There was a problem hiding this comment.
so as to not update the actual object and pass to regular user an object w/o gold_ans in it
pybossa/importers/csv.py
Outdated
| elif headers[idx].endswith('_gold'): | ||
| if 'gold_answers' not in task_data: | ||
| task_data['gold_answers'] = {} | ||
| task_data['gold_answers'][headers[idx].strip('_gold')] = cell |
There was a problem hiding this comment.
.strip removes all the characters in the '_gold' string, so that's not what you want here, e.g. 'old_gold'.strip('_gold') == ''
test/test_api/test_task_api.py
Outdated
| @patch('pybossa.api.task.validate_required_fields') | ||
| def test_task_post_api_exceptions(self, inv_field, dup): | ||
| """Get a list of tasks using a list of project_ids.""" | ||
| [admin, subadminowner, subadmin, reguser] = UserFactory.create_batch(4) |
There was a problem hiding this comment.
Do you need all these? Looks like only admin and subadminonwner are used
fiorda
reviewed
Oct 29, 2018
pybossa/importers/importer.py
Outdated
| def validate_gold_answers(task): | ||
| try: | ||
| if task.gold_answers: | ||
| json.dumps(task.gold_answers) |
dchhabda
force-pushed
the
1287-gold-task
branch
from
2b114bc
to
ec7765a
Compare
|
updated |
dchhabda
force-pushed
the
1287-gold-task
branch
from
ec7765a
to
dadee8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.