Fix CI target for Fedora #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hroncok do you know if there is any other way to obtain debugging symbols for the main executable of CPython in Fedora other than using |
pablogsal
force-pushed
the
fix_fedora
branch
from
6d6a9b4
to
f8bbf91
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 89.91% 89.71% -0.21%
==========================================
Files 48 48
Lines 5496 5505 +9
Branches 873 873
==========================================
- Hits 4942 4939 -3
- Misses 554 566 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Something like |
pablogsal
force-pushed
the
fix_fedora
branch
2 times, most recently
from
ab78ee5
to
5321c1c
Compare
hroncok
reviewed
Nov 16, 2023
hroncok
reviewed
Nov 16, 2023
pablogsal
force-pushed
the
fix_fedora
branch
6 times, most recently
from
aa31bcb
to
f543c03
Compare
Seems that the latest fedora image ships Python 3.12 with not enough debugging symbols to provide native information for core files. Apparently the python3-debug package only provides the debug version of the runtime and doesn't also provide split-debug information for the main executable. To obtain the symbols we need we need to manually install them by running `dnf debuginfo-install python3`. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal
force-pushed
the
fix_fedora
branch
3 times, most recently
from
72ac019
to
095a502
Compare
godlygeek
reviewed
Nov 16, 2023
To get the pthread id we copy a buffer of 200 pointers from the start of the pthread structure and try to match the pid inside. It is possible that the process doesn't have that much space available in a valid memory map so reading this much memory will fail. To fix this, try to reduce the size of the buffer by half every time we fail to copy from the process until we succeed or we reach 0. Signed-off-by: Pablo Galindo <pablogsal@gmail.com> Co-authored-by: Matt Wozniski <godlygeek@gmail.com>
pablogsal
force-pushed
the
fix_fedora
branch
from
f155794
to
b17f807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that the latest fedora image ships Python 3.12 with not enough
debugging symbols to provide native information for core files.
Apparently the python3-debug package only provides the debug version of
the runtime and doesn't also provide split-debug information for the
main executable.
Luckily, Fedora runs a debuginfod server that we can leverage to obtain
the debugging symbols that we need.