Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add sanity-check workflow: require DCO and news entry #68

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

austinlg96
Copy link
Contributor

@austinlg96 austinlg96 commented Apr 24, 2023

#55

Describe your changes
Copied Memray's sanity-check.yml workflow into pystack, as discussed offline.

Checks for:

Testing performed
Tested multiple pull requests on my fork:

Additional context
Part of PyCon 2023 Sprints

@austinlg96 austinlg96 changed the title Added sanity-check workflow for PRs: Req. DCO + news entry. Add sanity-check workflow for PRs: Req. DCO + news entry. Apr 24, 2023
Require PRs to have a new `news` file or the `skip news` label.

Also require commits to have a `Signed-off-by` DCO.

Signed-off-by: Austin G <19922895+austinlg96@users.noreply.github.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godlygeek godlygeek changed the title Add sanity-check workflow for PRs: Req. DCO + news entry. ci: Add sanity-check workflow: require DCO and news entry Apr 24, 2023
@godlygeek godlygeek merged commit 6de749f into bloomberg:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants