Add C++ coverage in CI and upload all coverage reports to CodeCov #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Apr 26, 2023
sarahmonod
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage ? 82.48%
=======================================
Files ? 27
Lines ? 3260
Branches ? 226
=======================================
Hits ? 2689
Misses ? 571
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sarahmonod
commented
Apr 28, 2023
This was referenced Apr 28, 2023
The only thing the "build" workflow is used for is coverage testing. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
Put them all in a single file and publish a report for both of them. Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
Now that the Cython code is also counted, we have a few more lines and branches that aren't covered. This change makes it so that CI passes even though, once we include the Cython code, the coverage is about 96% instead of 100% as it was earlier. Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #62
Describe your changes
This change will calculate the C++, Cython and Python coverage in CI, and upload the results to CodeCov. CodeCov then provides a PR hook to let you know if and how coverage has changed for any of these three.
Testing performed
I tested on a personal fork of the project, and have set-up the appropriate secrets for the official Bloomberg fork already. If everything goes well, this PR should be the only one necessary, and I feel more confident that it will now that I was able to test it on my own fork.
Additional context
See examples of what this would look like here:
Example PR causing coverage reduction: https://github.com/gusmonod/pystack/pull/11
Example PR causing no coverage reduction: https://github.com/gusmonod/pystack/pull/12