Build wheels from sdist #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
build_wheels_from_sdist
branch
2 times, most recently
from
069fdb3
to
65e814f
Compare
Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
It's very slow, and now we're building our wheels from our sdist, so we can have more confidence that our sdist is correct than `check_manifest` provides. Since we've removed our only pre-push hook, we can simplify our pre-commit configuration to assume every hook runs only on commit. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
build_wheels_from_sdist
branch
from
2bfb493
to
ad482d1
Compare
pablogsal
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that our sdists are correct by using them to produce our wheels.
Drop the
check_manifestlinter, as building the wheels that we test from the sdist is a more useful check of the sdist's correctness.