Skip to content

Commit

Permalink
Add 3.7 back in the versions tested by CI
Browse files Browse the repository at this point in the history
We want to keep testing 3.7 after all, because it was only marked EOL
recently, and that it still is pretty easy to do so (support in GH
actions).

Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
  • Loading branch information
sarahmonod committed Oct 16, 2023
1 parent ccc9423 commit 6e4d75b
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ env:
TIMEOUT: 30

jobs:
build_comdb2:
name: Build bloomberg/comdb2 from source
build_bloomberg_comdb2:
name: Build bloomberg-comdb2 from source
runs-on: ubuntu-latest
steps:
- name: Checkout bloomberg/comdb2 repository
- name: Checkout bloomberg-comdb2 repository
uses: actions/checkout@v4
with:
repository: bloomberg/comdb2
Expand Down Expand Up @@ -60,9 +60,9 @@ jobs:
make
)
'
- name: Archive comdb2 repo with build artifacts
- name: Archive bloomberg-comdb2 repo with build artifacts
run: 'tar czvf bloomberg-comdb2.tar.gz bloomberg-comdb2/'
- name: Upload comdb2 repo with build artifacts
- name: Upload bloomberg-comdb2 repo with build artifacts
uses: actions/upload-artifact@v3
with:
name: bloomberg-comdb2
Expand All @@ -71,9 +71,9 @@ jobs:
build_sdist:
name: Build python-comdb2 source distribution
runs-on: ubuntu-latest
needs: [build_comdb2]
needs: [build_bloomberg_comdb2]
steps:
- name: Download comdb2 build artifacts
- name: Download bloomberg-comdb2 with build artifacts
uses: actions/download-artifact@v3
with:
name: bloomberg-comdb2
Expand All @@ -92,15 +92,14 @@ jobs:
(cd bloomberg-comdb2/build && sudo make install) &&
rm -rf bloomberg-comdb2.tar.gz bloomberg-comdb2/
'
- name: Install python-comdb2 build-time dependencies
run: 'sudo apt-get install -qy pkg-config'
- uses: actions/checkout@v4
- name: 'Set up Python 3.8'
- name: 'Set up Python 3.7'
uses: actions/setup-python@v4 # note that this step overwrites the PKG_CONFIG_PATH variable
with:
python-version: '3.8'
python-version: '3.7' # the lowest version that we support in CI
- name: Build sdist
run: '
sudo apt-get install -qy pkg-config &&
PKG_CONFIG_PATH=/opt/bb/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig
pipx run build --sdist
'
Expand All @@ -122,6 +121,7 @@ jobs:
- '3.10'
- '3.9'
- '3.8'
- '3.7'
steps:
- name: Download comdb2 repo with build artifacts
uses: actions/download-artifact@v3
Expand Down Expand Up @@ -168,7 +168,7 @@ jobs:
with:
name: python-comdb2-sdist
path: dist
- name: Extract sdist
- name: Extract python-comdb2 sdist
run: '
(cd dist/ && tar xvf comdb2-*.tar.gz && rm comdb2-*.tar.gz) &&
mv dist/comdb2-* python-comdb2-sdist && rmdir dist
Expand All @@ -182,7 +182,7 @@ jobs:
echo "Creating $table_name from $table_file"
/opt/bb/bin/cdb2sql "$COMDB2_DBNAME" local "create table $table_name { $(cat $table_file) }"
done
- name: Set up Python ${{ matrix.python_version }}
- name: Set up Python ${{matrix.python_version}}
uses: actions/setup-python@v4 # note that this step overwrites the PKG_CONFIG_PATH variable
with:
python-version: "${{matrix.python_version}}"
Expand Down

0 comments on commit 6e4d75b

Please sign in to comment.