Fix MANIFEST.in and make CI tests build and use a source distribution instead of the source directly
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahmonod
force-pushed
the
fix-manifest
branch
22 times, most recently
from
1137194
to
1a9cc5e
Compare
sarahmonod
force-pushed
the
fix-manifest
branch
6 times, most recently
from
ae8d2a5
to
3a212d0
Compare
sarahmonod
force-pushed
the
fix-manifest
branch
2 times, most recently
from
318700f
to
6e4d75b
Compare
sarahmonod
changed the title
MANIFEST.in to also include pxd filesMANIFEST.in and make CI tests build and use a source distribution instead of the source directly
godlygeek
requested changes
Oct 20, 2023
godlygeek
previously approved these changes
Oct 20, 2023
I guess that the repo config made it so that the review was dismissed as soon as I pushed something else anyway 😞 Oh well, I'll get someone else to approve this on Monday probably. |
This was referenced Oct 21, 2023
sarahmonod
force-pushed
the
fix-manifest
branch
3 times, most recently
from
06dbc47
to
56d7aa8
Compare
This is required if anyone wants to use the sdist to build this from source. Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
This makes it possible to detect problems like a missing `.pxd` file. Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
We want to keep testing 3.7 after all, because it was only marked EOL recently, and that it still is pretty easy to do so (support in GH actions). Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
sarahmonod
force-pushed
the
fix-manifest
branch
from
56d7aa8
to
1bc9ad9
Compare
|
Changes since Matt approved this: https://github.com/bloomberg/python-comdb2/compare/6e4d75bc9b42b298f0243de7167ec65d9a28aecc..1bc9ad995007e95fbd8f8dddfaf58e9e914db0a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44 was closed when I (accidentally) force pushed to the branch, removing all commits that weren't on
main… Re-opening as another PR because I don't have the privileges required to re-open #44.