Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add install action in Makefile #28

Closed
tbrachkov opened this issue Nov 18, 2019 · 3 comments
Closed

Add install action in Makefile #28

tbrachkov opened this issue Nov 18, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@tbrachkov
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We don't have an install action in the Makefile.

Describe the solution you'd like
Add an install action to Makefile. This action will create folder and copy the products of the build action so the tool could be installed to usr/local/bin/xcdiff.

Describe alternatives you've considered
Provide package installer on the GitHub repo.

Additional context
This install action will be used by the Homebrew formula to install the tool.
@marciniwanicki
Copy link
Contributor

Oh, nice idea! If I understand correctly the steps:

  • build release executable
  • check if the file /usr/local/bin/xcdiff exists, if so, ask the user if it's OK to override the file
  • copy the executable file over to /usr/local/bin/xcdiff

As a result, the tool would work without dealing with PATH - sounds great :)

I am not sure if homebrew installation can work for us. The tool is pretty niche, the core homebrew repo accepts only well-known applications (@adamkhazi did some quick research).

@tbrachkov
Copy link
Contributor Author

tbrachkov commented Nov 20, 2019 •
edited
Loading

Yes pretty much what you described.
The only thing that I am not sure is if we needed to have this check before overriding the files, however if you prefer it that way it could be done.
Once we have the install action, adding Homebrew would not be so hard. I haven't checked what is the criteria to get your formula accepted to the homebrew repo. If that's not possible nothing is stoping us from creating a repo and host the formula for the time being. We had a discussion with @kwridan in #3
Installing via a privately hosted formula Homebrew commad would look like: brew install bloomberg/tap/xcdiff

@tbrachkov tbrachkov mentioned this issue Nov 20, 2019
Merged
@marciniwanicki marciniwanicki added the enhancement New feature or request label Nov 26, 2019
marciniwanicki pushed a commit that referenced this issue Nov 27, 2019
@tbrachkov @marciniwanicki
Add install action in the Makefile (#29)
8f825ff 
*Issue number of the reported bug or feature request: #28*

**Describe your changes**
Added install action in the make file that will first build and then create folders and copy all of the products to: `/usr/local/lib/xcdiff`.

**Testing performed**
Installed via: `make install`.

**Additional context**
This is just a proposal, of what we described in issue #28.

Signed-off-by: Todor Brachkov <tbrachkov@gmail.com>
@kwridan
Copy link
Contributor

kwridan commented Nov 28, 2019

I believe this is now resolved via #29 - thanks for pushing this through @tbrachkov 👍

@kwridan kwridan closed this as completed Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marciniwanicki @tbrachkov @kwridan