Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release documentation #129

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

kwridan
Copy link
Contributor

@kwridan kwridan commented Oct 3, 2023

Describe your changes

  • Added notes on releases notes generation whic can now be done in the GitHub UI
  • Update makefile to include a step to initiate homebrew formula updates via brew bump-formula-pr xcdiff --version=...

References

@kwridan kwridan marked this pull request as ready for review October 3, 2023 07:05
- Added notes on releases notes generation whic can now be done in the GitHub UI
- Update makefile to include a step to initiate homebrew formula updates via `brew bump-formula-pr xcdiff --version=...`

References:

- https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes#creating-automatically-generated-release-notes-for-a-new-release
- https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#submit-a-new-version-of-an-existing-formula

Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (97c4554) 96.95% compared to head (47e5c0b) 96.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          50       50           
  Lines        2894     2894           
=======================================
  Hits         2806     2806           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marciniwanicki marciniwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kwridan 👍

@kwridan kwridan merged commit 2b7edf9 into bloomberg:main Oct 3, 2023
5 checks passed
@kwridan kwridan deleted the update/release-doc branch October 3, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants