Add diff helper #131
Merged
Add diff helper #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwridan
force-pushed
the
update/consolidate-diffs
branch
from
db2af93
to
9b2a35e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 96.95% 97.04% +0.08%
==========================================
Files 50 50
Lines 2894 2874 -20
==========================================
- Hits 2806 2789 -17
+ Misses 88 85 -3
☔ View full report in Codecov by Sentry. |
- A new diff helper has been added for common comparator operations of diffing common elements - The helper introduces a new `DiffComparable` protocol which descriptors can conform to - Where possible comparators and descriptors were migrated to leverage it Test Plan: - Verify all unit and integration tests continue to pass (i.e. no diff in output format) Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
kwridan
force-pushed
the
update/consolidate-diffs
branch
from
9b2a35e
to
603936f
Compare
marciniwanicki
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
DiffComparabletype which descriptors can conform toTesting performed
Additional context
While working on #130 I noticed there was a small tidy up needed that wasn't directly related to platform filters but would aid its development so was pulled out as a separate change.