Fix issue causing resources within built products to be omitted from results #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…results - In the event a resource build file can't be to a path relative to the project, the file was getting omitted from the comparison results - Resource bundles produced by other target reside with the built products directory and don't yield relative paths to the project - As such when comparing projects that leverage resource bundles, the results didn't include them - To mitigate this we now fallback to using the file's raw path incase we can't resolve a relative path to it Test Plan: - Run xcdiff on a project that contains resource bundles - Verify they appear - Run unit tests Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
kwridan
force-pushed
the
fix/bundle-resources
branch
from
aee6a84
to
c2fc7ae
Compare
marciniwanicki
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Testing performed