Fix inaccurate embedded framework comparator results #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: bloomberg#32 - Embedded frameworks that had no settings/attributes within Xcode (e.g. the "Code Sign on Copy" not selected) were omitted from the list of frameworks considered for comparison - To resolve this we now consider all frameworks (as long as they have a `path` set) - Fixtures have been updated to test for this scenario Test Plan: - Run `xcdiff -g dependencies -v` with the `Fixtures` folder - Verify the `ProjectFramework.framework` is listed as having different code sign attributes Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
adamkhazi
approved these changes
Nov 28, 2019
| } | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| private func codeSignAttributes(for file: PBXBuildFile) -> Bool { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #32
Describe your changes
pathset)Test plan
xcdiff -g dependencies -vwith theFixturesfolderProjectFramework.frameworkis listed as having different code sign attributes