Use -json xcodebuild option when extracting resolved settings #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 44 44
Lines 1677 1679 +2
=======================================
+ Hits 1613 1615 +2
Misses 64 64
Continue to review full report at Codecov.
|
kwridan
previously approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Nice work! thanks @marciniwanicki
As an enhancement we could look into suppressing some of the xcodebuild output
e.g.
$ xcdff -g resolved_settings
2020-10-12 07:53:12.485 xcodebuild[74228:33668656] Unknown simulator cpu type (16777228)
2020-10-12 07:53:12.486 xcodebuild[74228:33668656] Unknown simulator cpu type (16777228)
2020-10-12 07:53:13.433 xcodebuild[74238:33668904] Unknown simulator cpu type (16777228)
...
Package.resolved
Outdated
Comment on lines
45
to
55
| "revision": "81bb2bb333eafa68f8ecd8187a4bb56d51e78e97", | ||
| "version": "7.14.0" | ||
| } | ||
| }, | ||
| { | ||
| "package": "XcodeProjCExt", | ||
| "repositoryURL": "https://github.com/tuist/XcodeProjCExt", | ||
| "state": { | ||
| "branch": null, | ||
| "revision": "21a510c225ff2bc83d5920a21d902af4b1e7e218", | ||
| "version": "0.1.0" |
There was a problem hiding this comment.
minor: latest master already has this
added 2 commits
October 16, 2020 08:02
Signed-off-by: Marcin Iwanicki <marcin.iwanicki@appliwings.com>
Signed-off-by: Marcin Iwanicki <marcin.iwanicki@appliwings.com>
marciniwanicki
force-pushed
the
feature/63-use-xcodebuild-showbuildsettings-with-json-parameter
branch
from
5fd54d2
to
43669dc
Compare
kwridan
approved these changes
Oct 16, 2020
marciniwanicki
deleted the
feature/63-use-xcodebuild-showbuildsettings-with-json-parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #63
Describe your changes
Use
-jsonparameter forxcodebuild -showBuildSettingscommand to simplify the output parsing.Testing performed
xcdiff -g resolved_settingson projects with different settings, verify the diff output is correctxcdiff -g resolved_settingson projects with the same settings, ensure no differences are found