-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub workflow for CI #93
Add GitHub workflow for CI #93
Conversation
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 47 47
Lines 1853 1853
=======================================
Hits 1783 1783
Misses 70 70 Continue to review full report at Codecov.
|
- Declaring all the current CI steps, lint, build and test as a GitHub workflow Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
- The workflow now limits the github token permissions - The workflow now leverages caching to speed up builds Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
5a119f0
to
b9dc537
Compare
Pushed a few updates to include:
Some example runs from my fork: On a PR: On main: The bit that I'm not a 100% sure on is CodeCov integration, we may need to add a GitHub secret to pass along its token. That may cause some friction on PRs from forks as secrets may not be available in that scenario 🤔 There's also a dedicated CodeCov action we may be able to leverage https://github.com/codecov/codecov-action |
I've ran another test with CodeCov enabled on my personal fork - I didn't need to setup a token for it either (seems to not be required for public repos) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
As a final test - here's an example verifying fork PRs workflows |
Describe your changes
xcdiff
GitHub workflow is being added for CIAdditional context
We'd like to migrate off of Travis to GitHub Actions, this PR introduces the GitHub workflow, once verified we can remove the
.travis.yml
file.