Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mobile Data #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use Mobile Data #2

wants to merge 5 commits into from

Conversation

simonmaddox
Copy link
Contributor

I added this because a project I'm working on needed it - I figured it'd be better offering it than not, even if you decide not to merge it.

I wanted to offer the user a choice of only updating in the background when they're on Wifi. Easy enough.

However, it gets a bit complicated - what if I arrive at my location, then 20 seconds later I connect to Wifi? I'd expect the locationChanged block to be called at that point, and everything then continue as normal.

So that's what this is. Unfortunately I've had to add a Reachability class to get the network updates - perhaps there's a better way - and I've started adding prefixes (although I never got around to the SJONetworkStatus enum values) so it doesn't clash with any other Reachability class.

@blork
Copy link
Owner

blork commented Feb 27, 2013

Thanks for this! I've taken a quick glance through your changes and it seems really good - I'm in two minds whether or not to merge it in though, as it seems a little out of the scope of the library. I'll take a closer look at the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants