Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua errors dont lead into a crash-to-desktop #93

Closed
BangL opened this issue Sep 20, 2017 · 3 comments
Closed

lua errors dont lead into a crash-to-desktop #93

BangL opened this issue Sep 20, 2017 · 3 comments
Assignees

Comments

@BangL
Copy link
Collaborator

BangL commented Sep 20, 2017

lua errors should lead into a crash, since anything else could even lead into savegame corruption.
plain pd2 and blt4w behaves like that, only blt4l does not.
i still think that an optional just-log debug mode is useful and legit for devs though.

@ZNixian ZNixian self-assigned this Sep 20, 2017
@ZNixian
Copy link
Member

ZNixian commented Sep 20, 2017

Do you have a sample mod that you know crashes on the windows version?

@BangL
Copy link
Collaborator Author

BangL commented Sep 20, 2017 via email

@ZNixian
Copy link
Member

ZNixian commented Sep 20, 2017

Okay, I've got basic support for generating a crash.txt file and exit()ing the game when an error occurs.

This can be disabled by setting BLT_CRASH to CONTINUE, in which case it will act as it does currently, only it also prints the Lua stacktrace to the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants