New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error messages for unknown rooms in the scraper #15

Closed

2 tasks done

blu3r4y opened this issue Oct 10, 2020 · 0 comments

Closed

2 tasks done

Remove error messages for unknown rooms in the scraper #15

blu3r4y opened this issue Oct 10, 2020 · 0 comments

Labels

good first issue scraper

Owner

blu3r4y commented Oct 10, 2020 •

edited

Loading

Do not raise errors on unknown rooms, instead, just add a note to the final log message, e.g.

scraped 42 room bookings for course '123456' (of which 12 unknown rooms were ignored: ['tba', 'unknown'])

Add a statistic counter on numIgnoredBookings which counts all bookings with unknown room names (non-unique)

Just as a note, here is a list of commonly unknown rooms:

-
n.n.
digital
divers
extern
hotel
kein
kusss
live
mail
moodle
offen
online
open
stream
tba
tbd
teams
todo
unbekannt
unknown
video
virtual
virtuell
zoom

The text was updated successfully, but these errors were encountered:

blu3r4y added scraper good first issue labels

blu3r4y added a commit that referenced this issue


          #5 #15 Load extraneous resources on rooms and buildings

blu3r4y added a commit that referenced this issue


          #15 Improve logging for unknown and ignored rooms

7ed5379

blu3r4y closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment