Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve logging output #139

Merged
merged 3 commits into from
Mar 26, 2024
Merged

feat: Improve logging output #139

merged 3 commits into from
Mar 26, 2024

Conversation

gmpinder
Copy link
Member

No description provided.

@gmpinder gmpinder added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Mar 26, 2024
@gmpinder gmpinder added this to the v0.8.3 milestone Mar 26, 2024
@gmpinder gmpinder self-assigned this Mar 26, 2024
@gmpinder gmpinder linked an issue Mar 26, 2024 that may be closed by this pull request
@gmpinder
Copy link
Member Author

gmpinder commented Mar 26, 2024

I decided to increase the amount of information you get the more verbose you set the logs to be. Here are the formats (my standard color scheme is orange fg and black bg):

  • Error, Warn, and Info level
    image

  • Debug Level
    image

  • Trace Level
    image

What's nice is, now the trace logging will display the line number in the code which will perfect for debugging!

@gmpinder
Copy link
Member Author

Thinking about it, probably don't want to have white for the time in case users use a white background

@gmpinder
Copy link
Member Author

Here's standard fg color for time

image

@gmpinder
Copy link
Member Author

And now with some proper padding

image

Copy link
Member

@xynydev xynydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, uhh, why is most of the text orange in your screenshot? Shouldn't color be used as a highlight and not just added to everything for the sake of it. Or is this a setting of your terminal?

@fiftydinar
Copy link
Contributor

fiftydinar commented Mar 26, 2024

Actually, uhh, why is most of the text orange in your screenshot? Shouldn't color be used as a highlight and not just added to everything for the sake of it. Or is this a setting of your terminal?

Orange color is usually used to indicate warning or attention, along with yellow for caution.

I think that terminals automatically switch colors from black to white & vice-versa when switching the theme.
So I'm not sure if there is a need to make everything orange to comply with black/dark & white themes.

@gmpinder
Copy link
Member Author

Actually, uhh, why is most of the text orange in your screenshot? Shouldn't color be used as a highlight and not just added to everything for the sake of it. Or is this a setting of your terminal?

The orange is my personal color scheme. The parts of the log that aren't orange are the colors that are added.

@gmpinder gmpinder merged commit 1891419 into main Mar 26, 2024
3 checks passed
@gmpinder gmpinder deleted the 36-feat-improve-module-logging branch March 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Improve module logging
3 participants