Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Signing module failing copying ublue-os cosign public key #317

Closed
gmpinder opened this issue Aug 10, 2024 · 6 comments
Closed

fix: Signing module failing copying ublue-os cosign public key #317

gmpinder opened this issue Aug 10, 2024 · 6 comments
Labels
priority: critical Should be done as soon as possible

Comments

@gmpinder
Copy link
Member

I'm seeing the error cp: cannot stat '/usr/share/ublue-os/cosign.pub': No such file or directory from the signing module. I'm not sure if this is something due to upstream but we should get this fixed

@gmpinder gmpinder added the priority: critical Should be done as soon as possible label Aug 10, 2024
@fiftydinar
Copy link
Collaborator

fiftydinar commented Aug 10, 2024

I got this error here:
#315

But it's gone when I reverted to signing module as is now.

However, you have this error without any modifications to signing module?

Yeah, this looks like it could be an upstream Ublue issue.

ublue-os/cosmic images also miss policy.json

So I think it's the issue with ublue-os-signing RPM package (not an Rechunker issue, since it's not used in main images, where issue can still be reproduced)

@gmpinder
Copy link
Member Author

Oh looks like the build errors I'm getting are cause of the change in main. I think I temporarily fixed it with this blue-build/cli@82606cc. I should release a patch version before we merge the module changes in

@xynydev
Copy link
Member

xynydev commented Aug 11, 2024

I didn't get this error with the main branch 15 hours ago nor now. Likely an issue with the PR then. Releasing a patch version is a good idea. I'll approve all the /usr/etc/ PRs, so y'all can merge them when ready. Notify me and I'll have the announcement posted everywhere. The next nine hours would be a good timespan for me for this, otherwise this change will get pushed back to next week.

@fiftydinar
Copy link
Collaborator

fiftydinar commented Aug 11, 2024

Oh looks like the build errors I'm getting are cause of the change in main. I think I temporarily fixed it with this blue-build/cli@82606cc. I should release a patch version before we merge the module changes in

Ah, makes sense why it works...

Agree on releasing a CLI patch version before merging PRs.

@fiftydinar
Copy link
Collaborator

@xynydev I'm ready & available for merging stuff in the similar time window as you.

@fiftydinar
Copy link
Collaborator

Fixed in BlueBuild CLI v0.8.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: critical Should be done as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants