-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple name auto-completion for the chat #37
Conversation
Todo: exclude bots from the auto-completion |
Things that would block me accept this:
Now, general coding sanity:
More specific to that current code:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't spot any apparent potential overflows any more. Good work! Please change these inline comments, I'll try the PR in the meantime.
src/engine/console.cpp
Outdated
|
||
char* name = strrchr(s, '@'); | ||
|
||
if (name) // autocomplete name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline comments. Please avoid.
No description provided.