Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use Alt + Backspace to delete entire words in the console #58

Merged
merged 8 commits into from
Jun 9, 2020
Merged

Add ability to use Alt + Backspace to delete entire words in the console #58

merged 8 commits into from
Jun 9, 2020

Conversation

MoonPadUSer
Copy link
Contributor

@MoonPadUSer MoonPadUSer commented Jun 9, 2020 •
edited by TheAssassin
Loading

Hold LALT and press backspace to delete an entire word in the console

Closes #54.

@MoonPadUSer MoonPadUSer mentioned this pull request Jun 9, 2020
Closed
TheAssassin
TheAssassin previously requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains not a single in-line comment. Please document what you've done. How are people supposed to know what your change's intentions were?

https://standards.mousepawmedia.com/csi.html

TheAssassin
TheAssassin reviewed Jun 9, 2020
View reviewed changes
src/engine/console.cpp Outdated Show resolved Hide resolved
src/engine/console.cpp Show resolved Hide resolved
src/engine/console.cpp Show resolved Hide resolved
@TheAssassin
Copy link
Member

Note for self: PR can and should be squashed.

TheAssassin
TheAssassin approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome idea, now with a solid implementation. Just tried it, really useful. Thanks!

@TheAssassin TheAssassin merged commit 130a670 into master Jun 9, 2020
@TheAssassin TheAssassin deleted the alt-backspace-to-remove-word branch June 9, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAssassin TheAssassin TheAssassin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alt + Backspace in the Console to delete entire words
2 participants
@MoonPadUSer @TheAssassin