Skip to content

Commit

Permalink
Updated coding standard and fixd errors
Browse files Browse the repository at this point in the history
  • Loading branch information
blue32a committed Apr 10, 2021
1 parent e1cbb58 commit 070dbc7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 15 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"league/flysystem-azure-blob-storage": "^1.0"
},
"require-dev": {
"blue32a/php-coding-standard": "v0.1.0-alpha",
"blue32a/php-coding-standard": "v0.3.0-alpha",
"mockery/mockery": "^1.3",
"php-parallel-lint/php-parallel-lint": "^1.3",
"phpunit/phpunit": "^8.5"
Expand Down
9 changes: 1 addition & 8 deletions src/AzureBlobStorageAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ class AzureBlobStorageAdapter extends BaseStorageAdapter
protected $publicEndpoint;

/**
* construct
*
* @param BlobRestProxy $client
* @param string $container
* @param string|null $prefix
Expand All @@ -33,21 +31,16 @@ public function __construct(BlobRestProxy $client, $container, $prefix = null)
parent::__construct($client, $container, $prefix);
}

/**
* @param string|null $publicEndpoint
* @return void
*/
public function setPublicEndpoint(?string $publicEndpoint): void
{
$this->publicEndpoint = $publicEndpoint;
}

/**
* return URL
* @see \Illuminate\Filesystem\FilesystemAdapter::url()
*
* @param string $path
* @return string
* @see \Illuminate\Filesystem\FilesystemAdapter::url()
*/
public function getUrl($path)
{
Expand Down
9 changes: 3 additions & 6 deletions tests/AzureBlobStorageAdapterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,8 @@ protected function createBlobRestProxyMock()

/**
* @test
* @return void
*/
public function testSetPublicEndpoint()
public function testSetPublicEndpoint(): void
{
$url = 'https://example.com';

Expand All @@ -63,9 +62,8 @@ public function testSetPublicEndpoint()

/**
* @test
* @return void
*/
public function testGetUrl()
public function testGetUrl(): void
{
$path = 'sample.txt';
$container = 'test';
Expand All @@ -91,9 +89,8 @@ public function testGetUrl()

/**
* @test
* @return void
*/
public function testGetUrlWithPublicEndpoint()
public function testGetUrlWithPublicEndpoint(): void
{
$path = 'sample.txt';
$container = 'test';
Expand Down

0 comments on commit 070dbc7

Please sign in to comment.