Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory offset #1032

Merged
merged 46 commits into from
Feb 12, 2024
Merged

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

related with #1031

crates/revm/src/evm.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol thing I noticed while reading

crates/interpreter/src/inner_models.rs Outdated Show resolved Hide resolved
@DoTheBestToGetTheBest
Copy link
Contributor Author

@rakita just followed what you told me todo

Copy link
Collaborator

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments

crates/interpreter/src/interpreter.rs Outdated Show resolved Hide resolved
crates/revm/src/evm.rs Outdated Show resolved Hide resolved
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rakita rakita merged commit 5670ee4 into bluealloy:main Feb 12, 2024
25 checks passed
This was referenced Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants