Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add evm script #1039

Merged
merged 7 commits into from
Mar 1, 2024
Merged

feat: add evm script #1039

merged 7 commits into from
Mar 1, 2024

Conversation

charles-cooper
Copy link
Contributor

add a script which can run arbitrary binaries

add a script which can run arbitrary binaries
@charles-cooper
Copy link
Contributor Author

sorry, i don't really know rust -- feedback welcome!

@rakita
Copy link
Member

rakita commented Feb 1, 2024

Maybe it would be best to integrate it in revme so you can get a binary you can reuse.
Just follow how other two commands are made:

FormatKzgSetup(format_kzg_setup::Cmd),

@charles-cooper
Copy link
Contributor Author

Maybe it would be best to integrate it in revme so you can get a binary you can reuse. Just follow how other two commands are made:

i kind of like how this binary benchmarks the evm code. should we do two different binaries? or maybe add a --bench option to the revme binary?

@rakita
Copy link
Member

rakita commented Feb 5, 2024

Maybe it would be best to integrate it in revme so you can get a binary you can reuse. Just follow how other two commands are made:

i kind of like how this binary benchmarks the evm code. should we do two different binaries? or maybe add a --bench option to the revme binary?

--bench option sounds great

@charles-cooper
Copy link
Contributor Author

--bench option sounds great

566c32f

@rakita
Copy link
Member

rakita commented Mar 1, 2024

--bench option sounds great

566c32f

Added a few more changes.
More flags so bytecode can be specified from cli, or from file with --path.
if the --bench is not active result will be printed. If --state is added, state accounts/storage will be outputed.
And added an option for --input by default it is empty.

@rakita rakita merged commit a89daef into bluealloy:main Mar 1, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
* feat: add evm script

add a script which can run arbitrary binaries

* fix lint

* move evm runner script to `revme` subcommand

* cargo fmt

* cli byecode,input,path, state options added, output result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants