Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf/refactor(precompile): simplify bn128 precompile implementations #1074

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Feb 10, 2024

Reduce stack and heap allocations, factor out some common code to separate functions/closures.

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice refactor

@DaniPopes DaniPopes merged commit a961c1f into bluealloy:main Feb 11, 2024
25 checks passed
@DaniPopes DaniPopes deleted the precompiles-2 branch February 11, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants