perf(precompile): use Bytes in precompile functions
#1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Feb 13, 2024
| let input = right_pad_vec(input, base_len + exp_len + mod_len); | ||
| let (base, input) = input.split_at(base_len); | ||
| let (exponent, modulus) = input.split_at(exp_len); | ||
| debug_assert_eq!(modulus.len(), mod_len); |
There was a problem hiding this comment.
Made this allocate only once in case input is too short.
modulus.len() must be mod_len due to the padding above, this is the same as slicing the input 3 times.
DaniPopes
force-pushed
the
dani/precompiles-bytes
branch
from
4acdf40
to
1ac744d
Compare
DaniPopes
commented
Feb 13, 2024
| @@ -26,8 +25,7 @@ pub fn right_pad<const LEN: usize>(data: &[u8]) -> Cow<'_, [u8; LEN]> { | |||
| Cow::Borrowed(data.try_into().unwrap()) | |||
| } else { | |||
| let mut padded = [0; LEN]; | |||
| let end = min(LEN, data.len()); | |||
| padded[..end].copy_from_slice(&data[..end]); | |||
| padded[..data.len()].copy_from_slice(data); | |||
There was a problem hiding this comment.
I realized these min calls were unnecessary since data.len() is always less than the input length by definition.
| let gas_used = calc_linear_cost_u32(input.len(), IDENTITY_BASE, IDENTITY_PER_WORD); | ||
| if gas_used > gas_limit { | ||
| return Err(Error::OutOfGas); | ||
| } | ||
| Ok((gas_used, input.to_vec())) | ||
| Ok((gas_used, input.clone())) |
There was a problem hiding this comment.
This is the biggest win IMO, avoids malloc+memcpy basically as if we're using Arc. identity precompile is common in code generated by Vyper.
|
nit clippy |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1072.