Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename and pass optimism-default-handler to revm-primitives #1098

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Feb 17, 2024

Follow up to this PR: #1091

Copy link
Contributor

Valgrind Results:

==4025== Cachegrind, a cache and branch-prediction profiler
==4025== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4025== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4025== Command: target/release/snailtracer
==4025== 
--4025-- warning: L3 cache found, using its data for the LL simulation.
Snailtracer Host+Interpreter benchmark (2.1s) ...            not enough samples
==4025== 
==4025== I   refs:      471,788,411
==4025== I1  misses:          6,086
==4025== LLi misses:          2,908
==4025== I1  miss rate:        0.00%
==4025== LLi miss rate:        0.00%
==4025== 
==4025== D   refs:      229,165,129  (152,346,578 rd   + 76,818,551 wr)
==4025== D1  misses:        350,871  (    210,617 rd   +    140,254 wr)
==4025== LLd misses:        137,582  (      4,060 rd   +    133,522 wr)
==4025== D1  miss rate:         0.2% (        0.1%     +        0.2%  )
==4025== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4025== 
==4025== LL refs:           356,957  (    216,703 rd   +    140,254 wr)
==4025== LL misses:         140,490  (      6,968 rd   +    133,522 wr)
==4025== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita changed the title rename and pass optimism-default-handler to revm-primitives fix: rename and pass optimism-default-handler to revm-primitives Feb 17, 2024
@rakita rakita merged commit b4a61e8 into main Feb 17, 2024
25 checks passed
This was referenced Feb 17, 2024
@DaniPopes DaniPopes deleted the fix-optimism-default-handler branch March 13, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant