Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make feature = "optional_gas_refund" work #1134

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Feb 29, 2024

Now the is_gas_refund_disabled api is configured by feature optional_gas_refund, but it's never be used.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks right

@rakita
Copy link
Member

rakita commented Feb 29, 2024

Would need to reintroduce this for mainnet. But this PR lgtm

@rakita rakita merged commit f1357fd into bluealloy:main Feb 29, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
@yjhmelody yjhmelody deleted the fix/optional_gas_refund branch February 29, 2024 13:18
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants