Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add insert method on instruction table #1167

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

Rjected
Copy link
Collaborator

@Rjected Rjected commented Mar 7, 2024

Adds an insert helper method on the instruction table, and adds a test for creating and using a custom instruction

@Rjected Rjected added the feature New feature or lib ability label Mar 7, 2024
crates/revm/src/builder.rs Outdated Show resolved Hide resolved
crates/revm/src/builder.rs Outdated Show resolved Hide resolved
crates/revm/src/builder.rs Outdated Show resolved Hide resolved
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left few nits

@rakita
Copy link
Member

rakita commented Mar 8, 2024

Made changes so i can merge it in next release

@rakita rakita merged commit 93557e9 into bluealloy:main Mar 8, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Mar 8, 2024
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
* feat: add insert method on instruction table

* fix test

* nits refactor in tests

* clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or lib ability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants