Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eip2935): Preload blockhash storage address #1395

Merged
merged 1 commit into from
May 11, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented May 11, 2024

Preload blockhash storage address so it does not panic on access in JournalState.

Behavior in EIP is undefined, and we would prefer if preloading stays.

fixing #1388 panic

Copy link
Contributor

Valgrind Results:

==4017== Cachegrind, a cache and branch-prediction profiler
==4017== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4017== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4017== Command: target/release/snailtracer
==4017== 
--4017-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.831630867s
==4017== 
==4017== I   refs:      429,374,974
==4017== I1  misses:          4,185
==4017== LLi misses:          2,815
==4017== I1  miss rate:        0.00%
==4017== LLi miss rate:        0.00%
==4017== 
==4017== D   refs:      206,206,073  (133,651,387 rd   + 72,554,686 wr)
==4017== D1  misses:        321,676  (    181,967 rd   +    139,709 wr)
==4017== LLd misses:        137,711  (      4,341 rd   +    133,370 wr)
==4017== D1  miss rate:         0.2% (        0.1%     +        0.2%  )
==4017== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4017== 
==4017== LL refs:           325,861  (    186,152 rd   +    139,709 wr)
==4017== LL misses:         140,526  (      7,156 rd   +    133,370 wr)
==4017== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit aeefcda into main May 11, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request May 11, 2024
rakita added a commit that referenced this pull request May 16, 2024
rakita added a commit that referenced this pull request May 16, 2024
* Revert "feat: implement EIP-2935 (#1354)"

This reverts commit 3e089f3.

* dont revert some commend changes

* Revert "fix(eip2935): Preload blockchash storage address (#1395)"

This reverts commit aeefcda.
@rakita rakita deleted the rakita/fix_preload_blockchash branch June 10, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant