Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EOF): Add CALLF/JUMPF stack checks #1417

Merged
merged 3 commits into from
May 14, 2024
Merged

feat(EOF): Add CALLF/JUMPF stack checks #1417

merged 3 commits into from
May 14, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented May 13, 2024

Adding stack checks for CALLF/JUMPF:

https://github.com/ipsilon/eof/blob/main/spec/eof.md
if 1024 < len(stack) + types[idx].max_stack_height - types[idx].inputs, execution results in an exceptional halt

Copy link
Contributor

github-actions bot commented May 13, 2024

Valgrind Results:

==4067== Cachegrind, a cache and branch-prediction profiler
==4067== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4067== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4067== Command: target/release/snailtracer
==4067== 
--4067-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.833002029s
==4067== 
==4067== I   refs:      429,372,715
==4067== I1  misses:          3,087
==4067== LLi misses:          2,794
==4067== I1  miss rate:        0.00%
==4067== LLi miss rate:        0.00%
==4067== 
==4067== D   refs:      206,205,448  (133,650,897 rd   + 72,554,551 wr)
==4067== D1  misses:        344,655  (    204,566 rd   +    140,089 wr)
==4067== LLd misses:        137,642  (      4,279 rd   +    133,363 wr)
==4067== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==4067== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4067== 
==4067== LL refs:           347,742  (    207,653 rd   +    140,089 wr)
==4067== LL misses:         140,436  (      7,073 rd   +    133,363 wr)
==4067== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita changed the title feat(EOF): Add CALLF stack check feat(EOF): Add CALLF/JUMPF stack checks May 13, 2024
@rakita rakita merged commit 84d1372 into main May 14, 2024
25 checks passed
This was referenced May 14, 2024
@github-actions github-actions bot mentioned this pull request Jun 8, 2024
@rakita rakita deleted the eof_callf_stack_check branch June 10, 2024 16:55
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant