Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EOF): panic on empty input range, and continue exec after eofcreate #1477

Merged
merged 13 commits into from
Jun 7, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jun 1, 2024

InstructionResult needs to be reset when eofcreate continues execution.

And Handle panic on empty range

@rakita rakita changed the base branch from rakita/eof_create_eip7698 to main June 7, 2024 11:08
@rakita rakita changed the base branch from main to rakita/eof_create_eip7698 June 7, 2024 11:09
@rakita rakita marked this pull request as ready for review June 7, 2024 11:13
@rakita rakita changed the base branch from rakita/eof_create_eip7698 to main June 7, 2024 11:14
@rakita rakita changed the title Rakita/temp fix(EOF): Fix pop order in call, and continue exec after eofcreate Jun 7, 2024
@rakita rakita changed the title fix(EOF): Fix pop order in call, and continue exec after eofcreate fix(EOF): panic on empty input range, and continue exec after eofcreate Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Valgrind Results:

==3776== Cachegrind, a cache and branch-prediction profiler
==3776== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3776== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3776== Command: target/release/snailtracer
==3776== 
--3776-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.810893088s
==3776== 
==3776== I   refs:      429,375,370
==3776== I1  misses:          3,142
==3776== LLi misses:          2,802
==3776== I1  miss rate:        0.00%
==3776== LLi miss rate:        0.00%
==3776== 
==3776== D   refs:      206,206,144  (133,651,464 rd   + 72,554,680 wr)
==3776== D1  misses:        345,426  (    205,298 rd   +    140,128 wr)
==3776== LLd misses:        137,725  (      4,326 rd   +    133,399 wr)
==3776== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3776== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3776== 
==3776== LL refs:           348,568  (    208,440 rd   +    140,128 wr)
==3776== LL misses:         140,527  (      7,128 rd   +    133,399 wr)
==3776== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita
Copy link
Member Author

rakita commented Jun 7, 2024

Note I assumed that there is wrong order of stack pop's for EXTCALL, but spec says that original impl was correct, and order is not same as CALL opcode. Order is: EXTCALL (0xf8) with arguments (target_address, input_offset, input_size, value)

@rakita rakita merged commit bdd1b8e into main Jun 7, 2024
25 checks passed
This was referenced Jun 7, 2024
@rakita rakita deleted the rakita/temp branch June 10, 2024 16:54
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant