feat: mutable access for all fields in BundleBuilder #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpgonzalezra
changed the title
rakita
reviewed
Jun 15, 2024
| pub fn state_storage( | ||
| mut self, | ||
| address: Address, | ||
| storage: &mut HashMap<U256, (U256, U256)>, |
There was a problem hiding this comment.
This is not what the requirement was.
It is to add get_state_storage_mut( function
There was a problem hiding this comment.
While we are at it, it would be good to add mut getters for all fields
There was a problem hiding this comment.
my bad, i'm going to fix it 💪
jpgonzalezra
changed the title
This was referenced Jun 16, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #1519 , let me know what do you think
Originally posted by @quentinv72 in paradigmxyz/reth#8264 (comment)
@rakita @gakonst
Closes #1519