-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any breaking changes I should be aware of for Foundry? 😄 |
rakita
commented
Feb 21, 2022
crates/revm/src/inspector.rs
Outdated
Comment on lines
48
to
53
fn call( | ||
&mut self, | ||
data: &mut EVMData<'_, DB>, | ||
call: H160, | ||
context: &CallContext, | ||
transfer: &Transfer, | ||
input: &Bytes, | ||
gas_limit: u64, | ||
inputs: &CallInputs, | ||
is_static: bool, | ||
) -> (Return, Gas, Bytes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onbjerg this is only change that is going to have a effect outside of revm. all those fields are now inside CallInputs
/CreateInputs
struct, so it will be relatively easy to upgrade.
Closed
This was referenced Feb 8, 2024
Merged
This was referenced Feb 16, 2024
Closed
This was referenced Mar 12, 2024
This was referenced Mar 22, 2024
Closed
Closed
Closed
Merged
This was referenced Apr 2, 2024
Merged
This was referenced Apr 16, 2024
This was referenced May 2, 2024
Closed
This was referenced May 13, 2024
Closed
Closed
Closed
Closed
This was referenced Sep 9, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Machine -> Interpreter
some name changes and refactoring of structure.