feat(state): take N reverts from BundleState, struct refactor #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
changed the title
rakita
force-pushed
the
take_account_reverts
branch
from
ca5fe13
to
367ee50
Compare
Closed
mikelodder7
pushed a commit
to LIT-Protocol/revm
that referenced
this pull request
Sep 12, 2023
…loy#681) * feat(state): take N reverts from BundleState * new line * nits, export and PartialEq,Eq * ftm
Evalir
pushed a commit
to Evalir/revm
that referenced
this pull request
Sep 14, 2023
…loy#681) * feat(state): take N reverts from BundleState * new line * nits, export and PartialEq,Eq * ftm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original function
detach_lower_part_revertsdidn't make sense to returnSelfas the returned Bundle state had just reverts. So remove it and make explicit function that handles return of the reverts.Additionally added structures to the long storage types that we had inside
PlainStateRevertandPlainStateChangesetthis increased the readability of types.This addresses few comments from this PR: #663