chore(state): Make Database more generic. #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Sep 5, 2023
Comment on lines
-31
to
+30
| impl Default for StateBuilder<'_, Infallible> { | ||
| impl Default for StateBuilder<Box<EmptyDB>> { |
There was a problem hiding this comment.
This can be made generic
impl<DB: Default> Default for StateBuilder<DB> {
This was referenced Sep 6, 2023
mikelodder7
pushed a commit
to LIT-Protocol/revm
that referenced
this pull request
Sep 12, 2023
* chore(state): Make database more generic * doc
Evalir
pushed a commit
to Evalir/revm
that referenced
this pull request
Sep 14, 2023
* chore(state): Make database more generic * doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the State database more generic and introduce
StateDBBoxas an alternative to the current type.