Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caches block hashes, but also computes a block hash based on the block number if no block hash was returned from the underlying database.
Retrieving block hashes can be expensive (as is the case with our forking backend in Foundry), but it is also important that block hashes for different blocks differ from each other
@draganrakita I was unsure where to put this - we need it for
cheats.roll
to work correctly in Foundry, but it would also be weird to have aset_block_hash
function in the database trait.Two alternatives I could think of:
CacheDB
here with this patchCurious to hear what you think