Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(state): make bundle state non-optional #828

Merged
merged 2 commits into from
Oct 23, 2023
Merged

chore(state): make bundle state non-optional #828

merged 2 commits into from
Oct 23, 2023

Conversation

rkrasiuk
Copy link
Collaborator

Description

There is no good reason to put BundleState in an Option. In the case of a missing pre-loaded bundle, the default can be used instead.

rakita
rakita approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the Idea for the option was to have optional bundle but this was flushed out inside StateBuilder and optional transition_state is used

@rakita rakita merged commit 11aa0c8 into bluealloy:main Oct 23, 2023
8 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/chore-state-bundle-option branch October 23, 2023 08:30
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @rakita