Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(primitives): don't duplicate the SpecId::enabled() logic #869

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

IaroslavMazur
Copy link
Contributor

  • remove unnecessary function/trait implementations

  • fix docs errors

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly revert public function they should stay, and remove few more lines in Spec::enabled

crates/primitives/src/db.rs Outdated Show resolved Hide resolved
crates/primitives/src/specification.rs Outdated Show resolved Hide resolved
crates/primitives/src/specification.rs Show resolved Hide resolved
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 903db25 into bluealloy:main Nov 19, 2023
8 checks passed
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants