Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Swift 5.0 #10

Merged
merged 1 commit into from
May 23, 2019
Merged

Support Swift 5.0 #10

merged 1 commit into from
May 23, 2019

Conversation

anatg
Copy link
Contributor

@anatg anatg commented May 16, 2019

This PR updates the repo's dependencies (SwiftDate, SnapKit) to versions supporting Swift 5.0 in addition to converting the codebase to Swift 5.0

@anatg anatg requested a review from a team as a code owner May 16, 2019 19:41
@melniker melniker requested a review from a team May 23, 2019 15:29
melniker
melniker approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@melniker melniker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved from me. I added mobile as a required approver since I'm not looking at the technical aspects of the PR at all; only confirming the lack of BA IP and acceptability to contribute externally

JovannyEspinal
JovannyEspinal approved these changes May 23, 2019
View reviewed changes
Copy link

@JovannyEspinal JovannyEspinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anatg anatg merged commit 1f70379 into master May 23, 2019
@anatg anatg deleted the swift-5-support branch June 26, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melniker melniker melniker approved these changes

@JovannyEspinal JovannyEspinal JovannyEspinal approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anatg @JovannyEspinal @melniker