Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set fill to none for hexagons with no value #17

Merged
merged 3 commits into from
Feb 7, 2017

Conversation

danwild
Copy link
Contributor

@danwild danwild commented Jul 4, 2016

G'day, me again :)

Currently for hexbin layer - gaps in data appear as black hexagons.
This PR is to update so that if there is no value, there's no hexagon (well, no fill anyway).

Cheers,
Dan

@danwild
Copy link
Contributor Author

danwild commented Feb 1, 2017

bump

(let me know if I should do anything else to get this merged in)

@reblace
Copy link
Contributor

reblace commented Feb 1, 2017

I totally didn't realize this PR was here. I'm SO SORRY :)

Anyhow, can you ensure your merge is aligned with the latest master? I've done away with bower in favor of using npm for all dependency tracking and also I've migrated to d3 v4. Your PR looks to be reintroducing the bower dependencies.

@danwild
Copy link
Contributor Author

danwild commented Feb 1, 2017

@reblace aha no worries that happens to me all the time ;)

mmm I had just merged your latest master in, can't see .bowerrc, bower.json files etc. in my branch so shouldn't be any conflict?

@reblace
Copy link
Contributor

reblace commented Feb 1, 2017

It's the ./src/lib directories. If you check the master on this repo, the ./src/lib directory is now gone.

@danwild
Copy link
Contributor Author

danwild commented Feb 1, 2017

ah ok, just gave them the flick

@reblace
Copy link
Contributor

reblace commented Feb 1, 2017

ok, about to get some sleep, but will check this out tomorrow or later this week. Thanks for the contrbution!

@reblace reblace merged commit b4080f6 into bluehalo:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants